Build child process tree in windows using wmic#8
Merged
benmerckx merged 2 commits intobenmerckx:masterfrom Feb 3, 2025
Merged
Conversation
This gives the running application room to exit gracefully instead of being forcefully closed.
jefvel
changed the title
wmic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On windows it would only find the process for the
cmdprocess, and in some cases it would not kill its spawned process. This PR useswmicto find its child PIDs and kill them too.Also use SIGTERM instead of SIGKILL when terminating running processes. This gives the running application room to exit gracefully instead of being forcefully closed.